
For me, it's the fact that not only his controversies were so much lesser, but also his successes were much less happenstance. The National Park and greater public lands system was a massive undertaking, and after about a century it has paid off tremendously. We went from a nation with some of the worst history of human caused extinctions, to the literal model for conservation across the globe.
Take into account the policy in the at the time leading up to Pearl Harbor. And maybe look up the reasons he had. Get a good in depth look at all the sides. In hindsight was he wrong for those things? Yes. Was he doing what he thought was best for the United States at the time? Yes.
I don't disagree that the war definitely helped to bring us out of the depression. Though there were things going on beforehand that helped to start moving the gears again such as the Emergency Banking Act of 1933. From some research I did in undergrad the work he did to help restore trust in the government from the American people with fireside chats is something I wish were still a thing. One question that comes to mind as there are some things he did (such as Japanese internment camps)pt1
I think thats a fair point about the fireside chats and about the Emergency Banking Act, some real transparency from our government is desperately needed and FDR did offer some level of relief from the Depression through his own decisions. I just don't think that any of this is enough to morally offset his failures.